Skip to content

Commit

Permalink
Update prettie+eslint to current recommendation (#192)
Browse files Browse the repository at this point in the history
* Added actual linting check with eslint

* Updated to Node 20 (current LTS)
  • Loading branch information
ckulka authored May 4, 2024
1 parent a35eeb8 commit 069a6c4
Show file tree
Hide file tree
Showing 7 changed files with 161 additions and 238 deletions.
14 changes: 0 additions & 14 deletions .eslintrc.yaml

This file was deleted.

3 changes: 3 additions & 0 deletions .github/workflows/pr-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ jobs:
run: npm ci

- name: Ensure files follow code style
run: npm run prettier:check

- name: Ensure files pass eslint checks
run: npm run lint

test:
Expand Down
2 changes: 1 addition & 1 deletion cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { defineConfig } from "cypress";

let config = {
const config = {
e2e: {
supportFile: false,
screenshotsFolder: "cypress/screenshots",
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/send-mail-with-php.msmtp.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe("Send mail with PHP", () => {
},
}).should((response) => {
expect(response.body.totalRecords).to.eql(1);
let mail = response.body.mailItems[0];
const mail = response.body.mailItems[0];
expect(mail.fromAddress).to.eql("[email protected]");
expect(mail.toAddresses).to.eql(["[email protected]"]);
expect(mail.body).to.eql("Email sent with PHP mail()\n");
Expand Down
4 changes: 4 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import tseslint from "typescript-eslint";
import eslintConfigPrettier from "eslint-config-prettier";

export default [...tseslint.configs.recommended, eslintConfigPrettier];
Loading

0 comments on commit 069a6c4

Please sign in to comment.