Multiple pull-secrets and optional fallback-secret #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckotzbauer
added
the
kind/feature
github-actions
bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
===========================================
+ Coverage 32.52% 55.28% +22.76%
===========================================
Files 7 2 -5
Lines 535 123 -412
===========================================
- Hits 174 68 -106
+ Misses 335 49 -286
+ Partials 26 6 -20
Continue to review full report at Codecov.
|
steelion
suggested changes
May 27, 2022
… by one when necessary
- refactor the ContainerImage struct. - refactor secrets iteration
…space_name env-variable
always return allImageCreds removed unnecessary error message from log-message removed unnecessary info message
update testcases for registry and syft-analysis
Signed-off-by: Christian Kotzbauer <[email protected]>
Signed-off-by: Christian Kotzbauer <[email protected]>
Signed-off-by: Christian Kotzbauer <[email protected]>
ckotzbauer
force-pushed
the
feature/pull-secrets
branch
from
a3c0f8a to
a57e0b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #83
@steelion