Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag name in documentation #666

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

hardwarefresser
Copy link
Contributor

Hi,

There is a small mistake in the documentation. The flag "fallback-pull-secret" has a wrong name: "fallback-image-pull-secret". Which leads to "Error: unknown flag" when copy+pasted into the flags used to run the service.

See the error here:

time="2024-07-09T12:00:36Z" level=info msg="spawning process: [/usr/local/bin/sbom-operator --dtrack-api-key=[...] --dtrack-base-url=[...] --fallback-image-pull-secret=[...] --format=cyclonedx --targets=dtrack --verbosity=debug]" app=vault-env
Error: unknown flag: --fallback-image-pull-secret
Usage:
  sbom-operator [flags]
[...]
Flags:
  -c, --config string                                 Path to the config-file.
 [...]
      --fallback-pull-secret string                   Fallback-Pull-Secret
[...]

Small mistake in the documentation. The flag "fallback-pull-secret" was had a wrong name: "fallback-image-pull-secret". Which leads to "Error: unknown flag"
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2024
@ckotzbauer
Copy link
Owner

Thanks for the finding this and this PR!!

@ckotzbauer ckotzbauer merged commit a593d81 into ckotzbauer:main Jul 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants