-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add new flags to toggle deletion of orphan projects, setting parent project and dtrack project name by k8s pod annotation #563
Conversation
…rent project and dtrack project name by k8s annotation feat: add two new flags to toggle deletion of orphan projects and setting parent project by k8s annotation feat: add new flags to toggle deletion of orphan projects, setting parent project and dtrack project name by k8s annotation readme readme readme readme readme readme readme release test release test chore: release 2.0.0 release test chore: release 2.0.1 release test chore: release 2.0.2 release test release test chore: release 2.0.4 release test chore: release 2.0.5 release test chore: release 2.0.6 cleanup test stuff
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 25.13% 28.20% +3.06%
==========================================
Files 6 6
Lines 565 500 -65
==========================================
- Hits 142 141 -1
+ Misses 406 339 -67
- Partials 17 20 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, this looks very promising. Only change-request: Could you please rename the delete-orphan-projects
feature everywhere to delete-orphan-images
? This would be a more generic naming regarding non-dtrack-usages.
The pipeline failure will be fixed by a rebase against main
. Thanks again!
Ok, we'll rename it :) |
I renamed the config Key "DeleteOrphanProjects" to "DeleteOrphanImages" |
Thanks a lot! |
This PR would add 3 new features:
Disable automatic deletion of Dtrack projects
New Argument:
delete-orphan-projects
delete-orphan-projects
false
true
Custom Projectname
New Argument:
dtrack-project-name-annotation-key
dtrack-project-name-annotation-key
false
""
Description
The key at kubernetes has to be suffixed with the container name the project is for. e.g.
my.project.name/my-nginx
.Important
The suffix regarding container name must not be added to the config value and must not include
/
. e.g.my.project.name
The value for a custom project name in dtrack by annotation at the specific Pod is written in the format of
project:version
or justproject
where version defaults tolatest
. E.g.MyParentProject
orMyParentProject:1.0
Parent Project at Dependency Track
New Argument:
dtrack-parent-project-annotation-key
dtrack-parent-project-annotation-key
false
""
Description
The key at kubernetes has to be suffixed with the container name the parent project is for. e.g.
my.parent.project/my-nginx
.The value for the parent project annotation at the specific Pod is written in the format of
project:version
or justproject
where version defaults tolatest
. E.g.MyParentProject
orMyParentProject:1.0
Important
The suffix regarding container name must not be added to the config value and must not include
/
. e.g.my.parent.project
Example Pod Annotation:
sbom-operator config: