Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add git-fallback-mode to workaround multi_ack issue #171

Merged
merged 3 commits into from
Sep 17, 2022

Conversation

ckotzbauer
Copy link
Owner

Signed-off-by: Christian Kotzbauer [email protected]

@ckotzbauer ckotzbauer added kind/bug Categorizes issue or PR as related to a bug. target/git labels Sep 10, 2022
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2022
@ckotzbauer ckotzbauer added this to the 0.17.0 milestone Sep 13, 2022
Signed-off-by: Christian Kotzbauer <[email protected]>
@ckotzbauer ckotzbauer force-pushed the fix/git-auth-multi-ack branch from 71cd4ca to d18191c Compare September 17, 2022 07:36
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Base: 26.26% // Head: 27.03% // Increases project coverage by +0.77% 🎉

Coverage data is based on head (9dbed86) compared to base (eb12f65).
Patch coverage: 9.80% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   26.26%   27.03%   +0.77%     
==========================================
  Files           5        5              
  Lines         434      503      +69     
==========================================
+ Hits          114      136      +22     
- Misses        301      353      +52     
+ Partials       19       14       -5     
Impacted Files Coverage Δ
internal/target/git/git.go 4.02% <6.12%> (-0.36%) ⬇️
internal/target/git/git_target.go 15.00% <100.00%> (ø)
internal/target/git/auth/github.go
internal/target/git/auth/token.go
internal/target/oci/oci_target.go 44.06% <0.00%> (ø)
internal/target/oci/oci.go 61.11% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Christian Kotzbauer <[email protected]>
@ckotzbauer ckotzbauer merged commit a2dfe03 into main Sep 17, 2022
@ckotzbauer ckotzbauer deleted the fix/git-auth-multi-ack branch September 17, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone fails with status 400 when trying to clone a private Azure DevOps repo
2 participants