feat: add pod namespace as tag in dtrack project #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to add the namespace name as tag in project of dtrack Fixes: #156
github-actions
bot
added
the
size/S
ckotzbauer
requested changes
Aug 27, 2022
There was a problem hiding this comment.
Hi @rvgud,
thanks for the request and the PR, this is very appreciated!
The ProcessSbom function is an interface of type Target. You have to add the parameter to the interface and other implementations too (git, oci)
ckotzbauer
added
the
kind/feature
ckotzbauer
approved these changes
Aug 29, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the namespace name as tag in project of dtrack
Fixes: #156