fix Kozea#1007 Make 'inherit' value work correctly for shorthand prop…

…erties * skip shorthand expansion for 'inherit' tokens, hereby applying parent styles
ckepper · Dec 13, 2021 · 5aceebb · 5aceebb
1 parent c22b211
commit 5aceebb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/tests/test_css_validation.py b/tests/test_css_validation.py
@@ -132,6 +132,11 @@ def test_spacing_invalid(rule):
     ('text-decoration-line: overline', {'text_decoration_line': {'overline'}}),
     ('text-decoration-line: overline blink line-through', {
         'text_decoration_line': {'blink', 'line-through', 'overline'}}),
+    ('text-decoration: none', {
+        'text_decoration_line': 'none',
+        'text_decoration_color': 'currentColor',
+        'text_decoration_style': 'solid'}),
+    ('text-decoration: inherit', { 'text_decoration': 'inherit'}),
 ))
 def test_decoration_line(rule, result):
     assert expand_to_dict(rule) == result

diff --git a/weasyprint/css/validation/expanders.py b/weasyprint/css/validation/expanders.py
@@ -357,7 +357,11 @@ def expand_text_decoration(base_url, name, tokens):
 
     for token in tokens:
         keyword = get_keyword(token)
-        if keyword in (
+
+        if keyword == 'inherit':
+            yield 'text_decoration', tokens[0].lower_value
+            return
+        elif keyword in (
                 'none', 'underline', 'overline', 'line-through', 'blink'):
             text_decoration_line.add(keyword)
         elif keyword in ('solid', 'double', 'dotted', 'dashed', 'wavy'):