Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position of code type dropdown panel #418

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix position of code type dropdown panel #418

merged 1 commit into from
Nov 16, 2022

Conversation

mmotyczynska
Copy link
Contributor

@mmotyczynska mmotyczynska commented Nov 14, 2022 •
edited
Loading

Fixes position of code type dropdown panel.

Closes #414.

Closes #415.

@mmotyczynska
Copy link
Contributor Author

mmotyczynska commented Nov 14, 2022 •
edited
Loading

BalloonPanelView properties names have been changed here ckeditor/ckeditor5#12262. Without updating it in this project the top and left position values of the code type dropdown panel could not be calculated properly.

pszczesniak
pszczesniak approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 and it works as expected.

@mlewand mlewand mentioned this pull request Nov 15, 2022
Closed
mlewand
mlewand approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlewand
Copy link
Contributor

mlewand commented Nov 16, 2022

I checked and this issue appeared in 35.1.0 (which is on the master) so I'll change the branch here and target it to master.

@mlewand mlewand changed the base branch from ghw/411-version-3530-bump to master November 16, 2022 13:37
@mlewand mlewand force-pushed the ghw/414-incorrect-position-of-code-type-dropdown branch from 269cd11 to 368f2c8 Compare November 16, 2022 13:39
@mlewand mlewand merged commit a87a555 into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pszczesniak pszczesniak pszczesniak approved these changes

@mlewand mlewand mlewand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discovery: Incorrect code type dropdown positioning Incorrect code type dropdown positioning
3 participants
@mmotyczynska @mlewand @pszczesniak