Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand DomConverter.blockElements with missing elements #9931

Merged
merged 5 commits into from
Jun 21, 2021

Conversation

jacekbogdanski
Copy link
Member

@jacekbogdanski jacekbogdanski commented Jun 21, 2021

Suggested merge commit message (convention)

Fix (engine): DomConverter.blockElements is missing some of the HTML block element names. Closes #9801. Closes #7863.

@maxbarnas maxbarnas self-requested a review June 21, 2021 09:28
@maxbarnas
Copy link
Contributor

All good, restarted the build job. Will wait for it to finish before merging.

@Reinmar
Copy link
Member

Reinmar commented Jun 21, 2021

Other (engine): Changed DomConverter.blockElements type to Set.<String>. Closes #3920.

This sounds like a breaking change. This is a part of a public API and we recommended adding elements to that array.

Secondly, the ticket that I opened in 2016 was opened when this thing was added in the first place and it made more sense then. Changing this now, without a good reason has a dubious ROI in my opinion. The cost here is in the fact that it's a breaking change.

@jacekbogdanski
Copy link
Member Author

@Reinmar thanks, I've reverted the type change. I've also changed the merge message into a fix, as it seems to be fixing some cases in code-block and markdown-gfm plugins.

@maxbarnas maxbarnas merged commit 67b4c7d into master Jun 21, 2021
@maxbarnas maxbarnas deleted the ck/9801-block-elements branch June 21, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete DomConverter.blockElements array Possible bug in handling newline element in blockqoute
3 participants