Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing the min size of the block image properly. #9616

Merged
merged 2 commits into from
May 5, 2021

Conversation

magda-chrzescian
Copy link
Contributor

Suggested merge commit message (convention)

Fix (image): The block image smaller than 50px should be resized to the minimum size. Closes #9300 .

@magda-chrzescian magda-chrzescian requested a review from oleq May 4, 2021 10:54
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK but it breaks the resizer logic

2021-05-04 14 12 15

I guess we'd need to replicate the same min-width 100%  logic on the JS side somehow. I'm not sure if this is worth the hassle, though. WDYT @magda-chrzescian ?

@magda-chrzescian
Copy link
Contributor Author

@oleq It actually didn't break it, this is the way it used to work. At least on the inline images branch, even stranger things happen on master ;)
image
It escalates when you set the block image size to a very little value and then convert it to the inline image - it doesn't have the min-size, so the image size changes significantly.
I was about to add a separate issue to address this problem, but I guess I could fix it in this PR. WDYT?

@magda-chrzescian magda-chrzescian requested a review from oleq May 5, 2021 07:03
@oleq
Copy link
Member

oleq commented May 5, 2021

I was about to add a separate issue to address this problem, but I guess I could fix it in this PR. WDYT?

I see no good reason to postpone the fix you proposed and mix it up with anything else. Let's have another issue with that. Can you create one?

@oleq oleq merged commit 7667757 into i/2052-inline-images May 5, 2021
@oleq oleq deleted the i/9300-small-image-in-cell branch May 5, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block images smaller than 50px render incorrectly in table cells
2 participants