I/9568 resizing linked images #9598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
requested changes
May 4, 2021
There was a problem hiding this comment.
Looks great 👍
We're missing a "real-life-scenario test", though. Well, as real as resizerMouseSimulator.dragTo() will allow.
Tests you added check what ._getResizeHost() would return (which is fine). Still, if the mechanics of the feature changes and _getResizeHost logic is gone in the future (and its tests...) the code will be vulnerable again. A real-life (user) scenario test will prevent that because it is immune to the changes under the hood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (image): It should be possible to resize a linked image with the image handles. Closes #9568.
Fix (image): It should be possible to resize an image nested in a to-do list. See #9568.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.