Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration guide for 26.0.0 + plugincollection-soft-required docs improved #9133

Merged
merged 9 commits into from
Mar 2, 2021
Merged

Migration guide for 26.0.0 + plugincollection-soft-required docs improved #9133

merged 9 commits into from
Mar 2, 2021

Conversation

Reinmar
Copy link
Member

@Reinmar Reinmar commented Mar 1, 2021 •
edited
Loading

Suggested merge commit message (convention)

Docs: Introduced "Migration" section and the guide regarding migration to 26.0.0. Reviewed plugincollection-soft-required. Closes #8902.

@Reinmar Reinmar changed the base branch from master to release March 1, 2021 14:31
@Reinmar Reinmar requested a review from pomek March 1, 2021 14:31
pomek
pomek approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

godai78
godai78 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@godai78 godai78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this proposed document and made certain minor amendments to it, but I find it approvable otherwise and therefore I approve it now with the immediate effect.

@Reinmar Reinmar linked an issue Mar 2, 2021 that may be closed by this pull request
Review the plugincollection-soft-required error documentation #8902
Closed
@Reinmar
Copy link
Member Author

Reinmar commented Mar 2, 2021

This shouldn't pass 🤔

@Reinmar
Copy link
Member Author

Reinmar commented Mar 2, 2021

LOL, the tests do fail. How didn't we spot this, @pomek? :P

@Reinmar Reinmar mentioned this pull request Mar 2, 2021
Closed
@godai78
Copy link
Contributor

godai78 commented Mar 2, 2021

This shouldn't pass

Wasn't something I was personally able to spot, sorry :D

AnnaTomanek
AnnaTomanek approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@AnnaTomanek AnnaTomanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some final fixes, looks fine to me 👍

@AnnaTomanek AnnaTomanek merged commit f597ddc into release Mar 2, 2021
@AnnaTomanek AnnaTomanek deleted the dll-docs branch March 2, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godai78 godai78 godai78 approved these changes

@pomek pomek pomek approved these changes

@AnnaTomanek AnnaTomanek AnnaTomanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@Reinmar @godai78 @AnnaTomanek @pomek @niegowski @psmyrek