Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8907: The image caption should be controlled using the toolbar button #9090

Merged
merged 37 commits into from
Mar 2, 2021

Conversation

oleq
Copy link
Member

@oleq oleq commented Feb 24, 2021

Suggested merge commit message (convention)

Other (image): The image caption should be controlled using the toolbar button and a command for better integration with image styles. Closes #8907.


Additional information

BREAKING CHANGE (image): The caption will no longer show up automatically when a caption-less image gets selected. To show the caption, use the button in the image toolbar or execute the ToggleImageCaptionCommand command (editor.execute( 'toggleImageCaption' )).

oleq and others added 30 commits January 28, 2021 13:31
@oleq oleq requested a review from niegowski February 24, 2021 11:16
@oleq
Copy link
Member Author

oleq commented Feb 24, 2021

TBH, the longer I use this feature with auto-focus when the caption shows up, the more I hate it. There are so many things happening at once (the toolbar disappears, image styles change, the caption appears, the caret moves). Also, on top of this, if we go this way, the user will (almost) never get the chance to read the placeholder and could be puzzled by this empty box under the image. 

WDYT @magda-chrzescian? (it's related to #8907 (comment))

@magda-chrzescian
Copy link
Contributor

magda-chrzescian commented Feb 25, 2021

@oleq I usually trust the impressions of using something and well, if it feels wrong, maybe we should just change it. But I'm still afraid that we will put the needs of the inexperienced user before the needs of someone who already got used to the editor and just wants to get things done quickly.

It would be nice to see this feature working with the image styles before making the final decision.

@niegowski niegowski merged commit 0fc2efd into i/2052-inline-images Mar 2, 2021
@niegowski niegowski deleted the i/8907-new-caption-behavior branch March 2, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants