Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated inline images with responsive images (srcset, sizes) #9043

Merged
merged 17 commits into from
Mar 16, 2021

Conversation

pkwasnik
Copy link
Contributor

Suggested merge commit message (convention)

Internal (image): Integrated inline images with responsive images. Closes #8777.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pkwasnik pkwasnik requested review from oleq and niegowski February 17, 2021 13:21
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is incomplete. There's no support for resizing handles
image.

Also, the upcast conversion pipeline configuration is incorrect. You can check it by setting a size for an inline image in a manual test and doing editor.setData( editor.getData() );

@pkwasnik pkwasnik requested a review from oleq February 25, 2021 23:04
@oleq oleq linked an issue Mar 12, 2021 that may be closed by this pull request
@oleq oleq requested review from magda-chrzescian and removed request for niegowski March 12, 2021 15:44
@magda-chrzescian
Copy link
Contributor

@oleq Resizing the images with the srcset causes content jumping in chrome (for both block and inline images):

resizing

The inline images are being resized only horizontally in Safari:
Resizing

@oleq
Copy link
Member

oleq commented Mar 15, 2021

I addressed the Safari issue in fcd1cfc. I couldn't reproduce the latter, though. Any ideas?

Copy link
Contributor

@magda-chrzescian magda-chrzescian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the comment: #9043 (comment)

@magda-chrzescian
Copy link
Contributor

I addressed the Safari issue in fcd1cfc. I couldn't reproduce the latter, though. Any ideas?

I can't reproduce it either, but it wasn't a single case while I was testing. I guess we can merge anyway and keep an eye on it in the inline-images branch and while the QA testing.

@magda-chrzescian magda-chrzescian merged commit 037110f into i/2052-inline-images Mar 16, 2021
@magda-chrzescian magda-chrzescian deleted the i/8777 branch March 16, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate inline images with responsive images (srcset, sizes)
3 participants