-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated inline images with responsive images (srcset, sizes) #9043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/ckeditor5-image/tests/imageresize/imageresizeediting.js
Outdated
Show resolved
Hide resolved
@oleq Resizing the images with the The inline images are being resized only horizontally in Safari: |
I addressed the Safari issue in fcd1cfc. I couldn't reproduce the latter, though. Any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the comment: #9043 (comment)
I can't reproduce it either, but it wasn't a single case while I was testing. I guess we can merge anyway and keep an eye on it in the inline-images branch and while the QA testing. |
Suggested merge commit message (convention)
Internal (image): Integrated inline images with responsive images. Closes #8777.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.