Table cell must always contain at least a paragraph #9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was possible for table cells to be entirely empty. However, a recent change introduced in 93dbbf9 changed the evaluation order for table cell children. This led to calling hasAnyAttribute on a null reference, which is not supported. Move isSingleParagraph check prior to hasAnyAttribute. isSingleParagraph is correctly calculated because it relies on the childCount for the table cell. Fixes #8941 Fixes #8917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (table): Editor should not crash while downcasting in the data pipeline if any cell does not contain at least an empty paragraph. Closes #8941. Closes #8917. Closes #8979.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.