Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating image url input and disabling media insert button when inp… #8271

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

pkwasnik
Copy link
Contributor

…ut is empty

Suggested merge commit message (convention)

Fix (image, media-embed): Validating image url input and disabling media insert button when input is empty. Closes #7917.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pkwasnik pkwasnik requested a review from jodator October 16, 2020 07:56
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I've changed one thing from the original code. I think that we should expose isEnabled as Boolean and we can to it easily with binding and custom callback (not directly stated in the docs).

packages/ckeditor5-media-embed/tests/mediaembedui.js Outdated Show resolved Hide resolved
packages/ckeditor5-media-embed/tests/mediaembedui.js Outdated Show resolved Hide resolved
packages/ckeditor5-media-embed/src/ui/mediaformview.js Outdated Show resolved Hide resolved
@jodator jodator merged commit 608baa9 into master Oct 16, 2020
@jodator jodator deleted the i/7917 branch October 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inserting images via URL does not validate input
2 participants