Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declarative reconversion using triggerBy #8099

Merged
merged 119 commits into from
Oct 13, 2020
Merged

Declarative reconversion using triggerBy #8099

merged 119 commits into from
Oct 13, 2020

Commits on Aug 11, 2020

  1. PoC: Create complex re-render with slot conversion example.

    @jodator
    jodator committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    0b1e50e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. PoC: Document box view output in JSX-ish notation.

    @jodator
    jodator committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    f467fce View commit details
    Browse the repository at this point in the history

  2. PoC: Initial 'refresh' downcast action.

    @jodator
    jodator committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    7d85e32 View commit details
    Browse the repository at this point in the history

  3. PoC: Refresh conversion - retain "slot" children.

    @jodator
    jodator committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    7be4b06 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. PoC: Add render id to the view element itself.

    @jodator
    jodator committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    9bd831f View commit details
    Browse the repository at this point in the history

  2. PoC: Implement triggerBy handling.

    @jodator
    jodator committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    aa55061 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Merge branch 'master' into i/7956 

    # Conflicts:
#	packages/ckeditor5-engine/src/conversion/downcastdispatcher.js
    @jodator
    jodator committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    120af23 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Revert POC code.

    @jodator
    jodator committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a8f35ad View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @jodator
    jodator committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    dbc1ed6 View commit details
    Browse the repository at this point in the history

  3. Add base scenarios for re-converting using triggerBy.

    @jodator
    jodator committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    1a4245b View commit details
    Browse the repository at this point in the history

  4. Make triggerBy test example to use a more complex view.

    @jodator
    jodator committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    cfe4658 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Refactor tests to simple and complex scenarios.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    5f77aae View commit details
    Browse the repository at this point in the history

  2. Add tests for complex view structure without children.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    2c95c02 View commit details
    Browse the repository at this point in the history

  3. Unify test cases names.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    89e6afa View commit details
    Browse the repository at this point in the history

  4. Add tests for slot conversion.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    dff6f2f View commit details
    Browse the repository at this point in the history

  5. Update test cases for slot conversion.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    703ac9e View commit details
    Browse the repository at this point in the history

  6. Add more cases for memoization in downcast converter.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    a30c086 View commit details
    Browse the repository at this point in the history

  7. Fix case of re-converting main element on child add.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c2609ac View commit details
    Browse the repository at this point in the history

  8. Add test for removing a slot element.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    28bd1cf View commit details
    Browse the repository at this point in the history

  9. Typo fix.

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    16d18d4 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into i/7956-reconversion-trigger-by

    @jodator
    jodator committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    213cb9d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Move poc code to downcastDispatcher.convertChanges().

    @jodator
    jodator committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    ffc29a6 View commit details
    Browse the repository at this point in the history

  2. Remove redundant slice and move it to return statements.

    @jodator
    jodator committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    7e7e4b7 View commit details
    Browse the repository at this point in the history

  3. Inline poc code into DowncastDispatcher.convertChanges().

    @jodator
    jodator committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    bd192b5 View commit details
    Browse the repository at this point in the history

  4. Refactor downcasthelpers tests.

    @jodator
    jodator committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9164e3c View commit details
    Browse the repository at this point in the history

  5. Use re-render whole element with triggerBy in table downcast conversion.

    @jodator
    jodator committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    2b9bd51 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Add test cases for various slot conversion scenarios.

    @jodator
    jodator committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    5da1570 View commit details
    Browse the repository at this point in the history

  2. Update links to issues.

    @jodator
    jodator committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    93dedac View commit details
    Browse the repository at this point in the history

  3. Handle child removal on parent refresh in the differ.

    @jodator
    jodator committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    5b3a700 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. Handle attribute change on refreshed node.

    @jodator
    jodator committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    9fa12db View commit details
    Browse the repository at this point in the history

  2. Update the differ tests for "refresh" changes handling.

    @jodator
    jodator committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    5507aab View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Merge branch 'master' into i/7956-reconversion-trigger-by

    @jodator
    jodator committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1013f0e View commit details
    Browse the repository at this point in the history

  2. Handle remove when converting refresh change.

    @jodator
    jodator committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a8ab011 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Merge branch 'master' into i/7956-reconversion-trigger-by

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    db3b0cc View commit details
    Browse the repository at this point in the history

  2. Handle item refresh in downcast dispatcher.

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    e3b8c4e View commit details
    Browse the repository at this point in the history

  3. Trigger conversion on adding a slot with new content.

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    1b65b1a View commit details
    Browse the repository at this point in the history

  4. Fix test cases for slot reconversion.

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    db8c17a View commit details
    Browse the repository at this point in the history

  5. Update slot conversion tests formatting.

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    63f4b30 View commit details
    Browse the repository at this point in the history

  6. Skip tests that should be covered by #1589.

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    36f8d1e View commit details
    Browse the repository at this point in the history

  7. Remove debug code.

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    74a777a View commit details
    Browse the repository at this point in the history

  8. Update documentation of the downcast dispatcher and downcast helpers.

    @jodator
    jodator committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    64d11de View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Skip hanging tests.

    @jodator
    jodator committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    df4c370 View commit details
    Browse the repository at this point in the history

  2. Do not relay on particular API in table cell refresh post-fixer tests.

    @jodator
    jodator committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    5a00cbb View commit details
    Browse the repository at this point in the history

  3. Rewrite table cell refresh post-fixer to use new refresh mechanism on… 

    … paragraphs instead of table cells.
    @jodator
    jodator committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    62a3fb3 View commit details
    Browse the repository at this point in the history

  4. WiP: Update differ & downcast dispatcher cooperation on refresh change.

    @jodator
    jodator committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    b7a2c84 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Bring back attribute hindering in differ as "refresh" change should b… 

    …e handled the same way as "insert" in terms of attributes.
    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    ece9999 View commit details
    Browse the repository at this point in the history

  2. Adjust table downcast conversion to anticipate external converter for… 

    … paragraph.
    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    8125eee View commit details
    Browse the repository at this point in the history

  3. Move view refreshing logic from downcast helpers to the dispatcher.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    ab6468a View commit details
    Browse the repository at this point in the history

  4. Code style in tests.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    c3e7471 View commit details
    Browse the repository at this point in the history

  5. Remove old Differ.refreshItem with poc implementation.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    a081176 View commit details
    Browse the repository at this point in the history

  6. Remove refreshItem checks for table cell refresh post-fixer tests.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    544a1c9 View commit details
    Browse the repository at this point in the history

  7. Update differ code and tests for coverage.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    11eb06d View commit details
    Browse the repository at this point in the history

  8. Update differ code and tests for coverage.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    fb1fd1b View commit details
    Browse the repository at this point in the history

  9. Skip table tests causing infinite differ.getChanges() loop.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    8dc9244 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into i/7956-reconversion-trigger-by

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    7eefb61 View commit details
    Browse the repository at this point in the history

  11. Bring back table clipboard tests formatting.

    @jodator
    jodator committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    000d50b View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Typo fix.

    @jodator
    jodator committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    ef19033 View commit details
    Browse the repository at this point in the history

  2. Skip main event.

    @jodator
    jodator committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    4a9beb2 View commit details
    Browse the repository at this point in the history

  3. Bring back table re-insert to previous implementation of differ.refre… 

    …shItem().
    @jodator
    jodator committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    d11e778 View commit details
    Browse the repository at this point in the history

  4. Bring back tests for Differ.reInsertItem (old refreshItem).

    @jodator
    jodator committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    09b5baa View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Refactor DowncastDispatcher.convertChanges().

    @jodator
    jodator committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    ac56842 View commit details
    Browse the repository at this point in the history

  2. Refactor DowncastDispatcher.convertRefresh().

    @jodator
    jodator committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    45076c9 View commit details
    Browse the repository at this point in the history

  3. Refactor internal method names.

    @jodator
    jodator committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    cf6e4fc View commit details
    Browse the repository at this point in the history

  4. Remove useless checks in reconvert element handling.

    @jodator
    jodator committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    c02fe65 View commit details
    Browse the repository at this point in the history

  5. Refactor DowncastDispatcher._reconvertElement() API.

    @jodator
    jodator committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    a36d954 View commit details
    Browse the repository at this point in the history

  6. Differ refresh should not be converter on newly inserted items.

    @jodator
    jodator committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    6c707ff View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Refresh change should be forfeit also when inside range insert (multi… 

    …ple nodes).
    @jodator
    jodator committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3e9c9eb View commit details
    Browse the repository at this point in the history

  2. Consequent element refresh should be handled as one change.

    @jodator
    jodator committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    adfba56 View commit details
    Browse the repository at this point in the history

  3. Add tests for multiple non-overlapping refresh changes.

    @jodator
    jodator committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    60740f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Minor leftover fixes.

    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    225ea0e View commit details
    Browse the repository at this point in the history

  2. Bring back table cell paragraph post-fixer tests.

    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    8c29821 View commit details
    Browse the repository at this point in the history

  3. Add info about follow-ups to the code & comments cleanup.

    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    8ba1791 View commit details
    Browse the repository at this point in the history

  4. Update API of slot binding.

    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    e7f161c View commit details
    Browse the repository at this point in the history

  5. Revert article manual tests and create slot conversion manual test in… 

    … the engine package.
    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    1c24874 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into i/7956-reconversion-trigger-by

    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    e49cb63 View commit details
    Browse the repository at this point in the history

  7. Add ui as a dev dependencies for the engine feature.

    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7b0dafc View commit details
    Browse the repository at this point in the history

  8. Update table-cell-refresh-post-fixer comments and internal code.

    @jodator
    jodator committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    270359f View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Merge branch 'master' into i/7956-reconversion-trigger-by

    @jodator
    jodator committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    c3b15ce View commit details
    Browse the repository at this point in the history

  2. Move paragraph converter from table editing to conversion/downcast.

    @jodator
    jodator committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    93dbbf9 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Minor fixes in manual test.

    @niegowski
    niegowski committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    76a48bd View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Kuba Niegowski <[email protected]>
    @jodator @niegowski
    jodator and niegowski authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3d5bea5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into i/7956-reconversion-trigger-by 

    # Conflicts:
#	packages/ckeditor5-engine/package.json
    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    a671ed5 View commit details
    Browse the repository at this point in the history

  3. Update reconversion documentation for DowncastDispatcher.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3079ff7 View commit details
    Browse the repository at this point in the history

  4. Remove duplicated code from DowncastDispatcher.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9421571 View commit details
    Browse the repository at this point in the history

  5. Add early return for text attribute change in automatic element refre… 

    …shing.
    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    7e50748 View commit details
    Browse the repository at this point in the history

  6. Updates docs in DowncastHelpers.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    d9e6049 View commit details
    Browse the repository at this point in the history

  7. Remove helper method from a global scope in downcasthelpers.js.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9f01122 View commit details
    Browse the repository at this point in the history

  8. Explain why slot-to-view mapping is needed in mapper.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    1f67593 View commit details
    Browse the repository at this point in the history

  9. Remove intermediate array.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    61fd0d2 View commit details
    Browse the repository at this point in the history

  10. Update the automatic element refreshing in DowncastDispatcher.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b5b227d View commit details
    Browse the repository at this point in the history

  11. Update information about number of "x" actions for each change in the… 

    … differ.
    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    8428d9e View commit details
    Browse the repository at this point in the history

  12. Update packages/ckeditor5-table/src/converters/table-cell-refresh-pos… 

    …t-fixer.js

Co-authored-by: Kuba Niegowski <[email protected]>
    @jodator @niegowski
    jodator and niegowski authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f6b1327 View commit details
    Browse the repository at this point in the history

  13. Add memoization check to table-cell-refresh-post-fixer tests.

    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    a8846e6 View commit details
    Browse the repository at this point in the history

  14. Refactor, again, how table cell refresh post-fixer check which paragr… 

    …aph should be refreshed.

Using mapper should guarantee that we do a minimal set of changes. The previous implementations did not check for attribute changes.
    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    7d825c3 View commit details
    Browse the repository at this point in the history

  15. Refactor, again, how table cell refresh post-fixer check which paragr… 

    …aph should be refreshed.

Using mapper should guarantee that we do a minimal set of changes. The previous implementations did not check for attribute changes.
    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    c123cf3 View commit details
    Browse the repository at this point in the history

  16. Remove caching of already refreshed items. 

    Unfortunately, this do not work. Some tests hangs if post-fixer return true. When we do not re-run the post-fixer it will not enter "if" clause.
    @jodator
    jodator committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    a8d8208 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Refactored check for refresh trigger event mapping.

    @jodator
    jodator committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    eba356c View commit details
    Browse the repository at this point in the history

  2. Add jsdoc comment.

    @jodator
    jodator committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    a143f8f View commit details
    Browse the repository at this point in the history

  3. Update comment.

    @jodator
    jodator committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    64ae08b View commit details
    Browse the repository at this point in the history

  4. Add child consuming for slot conversion manual test.

    @jodator
    jodator committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    85bec0b View commit details
    Browse the repository at this point in the history

  5. Update comments.

    @jodator
    jodator committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    83da738 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Szymon Cofalik <[email protected]>
    @jodator @scofalik
    jodator and scofalik authored Oct 8, 2020
    Configuration menu
    Copy the full SHA
    3c82a08 View commit details
    Browse the repository at this point in the history

  2. Change how the downcast dispatcher handles triggerBy attribute for re… 

    …freshing.
    @jodator
    jodator committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    0f59a7a View commit details
    Browse the repository at this point in the history

  3. Revert differ changes.

    @jodator
    jodator committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    8081dce View commit details
    Browse the repository at this point in the history

  4. Add more tests for the re-conversion scenarios.

    @jodator
    jodator committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    7e359d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Fix view elements memoization.

    @jodator
    jodator committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    467ebcc View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Remove slot binding after changes in memoization done by DowncastDisp… 

    …atcher.
    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    9704c97 View commit details
    Browse the repository at this point in the history

  2. Change triggerBy configuration API.

    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    4abbf4a View commit details
    Browse the repository at this point in the history

  3. Rename conversion refresh to reconversion.

    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    39592eb View commit details
    Browse the repository at this point in the history

  4. Refactor DowncastDispatcher#_mapChangesWithAutomaticReconversion().

    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    7c85c64 View commit details
    Browse the repository at this point in the history

  5. Add comments to DowncastDispatcher#reconvertElement().

    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    019066e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into i/7956-reconversion-trigger-by

    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    dc85a1e View commit details
    Browse the repository at this point in the history

  7. Rename DowncastDispatcher#mapReconversionTriggerEvent to _mapReconver… 

    …sionTriggerEvent() as it is a protected method.
    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    e8921b6 View commit details
    Browse the repository at this point in the history

  8. Update jsdocs of the reconvertElement methods.

    @jodator
    jodator committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    2a5e54a View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Update logic for ignoring text changes when mapping events to reconve… 

    …rsion actions.
    @jodator
    jodator committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    e31c77a View commit details
    Browse the repository at this point in the history

  2. Remove Array.isArray() check for configuration option. 

    An early Exception will tell developer that the config provided is wrong.
    @jodator
    jodator committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    b8c5703 View commit details
    Browse the repository at this point in the history

  3. Fix manual test.

    @jodator
    jodator authored Oct 13, 2020
    Configuration menu
    Copy the full SHA
    73c2fb8 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Kuba Niegowski <[email protected]>
    @jodator @niegowski
    jodator and niegowski authored Oct 13, 2020
    Configuration menu
    Copy the full SHA
    857343b View commit details
    Browse the repository at this point in the history

  5. Update DowncastDispatcher#_mapChangesWithAutomaticReconversion() docs.

    @jodator
    jodator committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    d193903 View commit details
    Browse the repository at this point in the history