Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conversion API to upcast and downcast helpers #7797

Merged
merged 8 commits into from
Aug 7, 2020
Merged

Added conversion API to upcast and downcast helpers #7797

merged 8 commits into from
Aug 7, 2020

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Aug 7, 2020

Suggested merge commit message (convention)

Feature (engine): Added conversion API to upcast and downcast helpers. Closes #7334.

MAJOR BREAKING CHANGE (engine): config.view callback of DowncastHelpers takes DowncastConversionApi instead of DowncastWriter. See #7334.

MAJOR BREAKING CHANGE (engine): config.model callback of UpcastHelpers takes UpcastConversionApi instead of ModelWriter. See #7334.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS the only thing to change are some docs changes - I'll handle this and merge it.

@jodator jodator merged commit 16c9711 into master Aug 7, 2020
@jodator jodator deleted the t/7334 branch August 7, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One-way elementToElement() converters could have access to conversionApi
2 participants