Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing will not trigger other viewDocument#mousedown events #7550

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Conversation

pomek
Copy link
Member

@pomek pomek commented Jul 3, 2020

Suggested merge commit message (convention)

Fix (widget): The resizing mechanism will not trigger other view.Document#mousedown events. Thanks to that while resizing an image inside a cell, the mouse will not trigger the table's actions. Closes #6755.

@pomek pomek requested a review from jodator July 3, 2020 12:43
@jodator jodator self-assigned this Jul 6, 2020
@jodator
Copy link
Contributor

jodator commented Jul 6, 2020

Unfortunatelly, there is some kind of weird issue (maybe due to changed priorities or maybe browsers just suck...)

On Chrome it sometimes doesn't work correctly - below are 3 tries - all have different result:

  1. Failed to start (image dragged) resizing "works", no size feedback. Size saved.
  2. Drag started, no size feedback. Size not saved.
  3. Drag started (ignore the selection on other stuff), size feedback visible. Size saved.

On Firefox the most common scenario is "2".

If I set priority to 'normal' it backs to working normally AFAICS but the bug with table select gets back.

@pomek
Copy link
Member Author

pomek commented Jul 6, 2020

WHAT about switching priorities? I mean: low for events in TableMouse and normal (as it is on master) for resizing?

@jodator
Copy link
Contributor

jodator commented Jul 6, 2020

I feel like there's some bigger dpendency tree of those events which might behave differently in FF and Chrome and I don't have a clue why is that.

OTOH, I'd check this: #4600 if it could solve this problem (assuming revert to old Resizer events handling :( )

@pomek
Copy link
Member Author

pomek commented Jul 6, 2020

@jodator, could you check the PR once again?

Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/ckeditor5-widget/src/widgetresize/resizer.js Outdated Show resolved Hide resolved
@jodator jodator merged commit 27fce4e into master Jul 6, 2020
@jodator jodator deleted the i/6755 branch July 6, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table selection is active during image resize
2 participants