Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#407: Brought the feature allowing users to type in tight spots around block widgets #6794

Merged
merged 67 commits into from
May 14, 2020
Merged

#407: Brought the feature allowing users to type in tight spots around block widgets #6794

merged 67 commits into from
May 14, 2020

Commits on May 7, 2020

  1. The initial implementation of the widget type around feature.

    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    690b7ba View commit details
    Browse the repository at this point in the history

  2. Created a manual test for the widget type around feature.

    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    e022336 View commit details
    Browse the repository at this point in the history

  3. Added the button icon file for the type around feature.

    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    727514e View commit details
    Browse the repository at this point in the history

  4. Made the .ck-horizontal-line use display: flow-root to get rid of o… 

    …verflow colliding with the type around feature.
    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    0773651 View commit details
    Browse the repository at this point in the history

  5. Set position: relative on all widgets to allow the type around feat… 

    …ure to position its UI.
    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    4a53d8e View commit details
    Browse the repository at this point in the history

  6. Excluded the "return-arrow" icon from the clean-up-svg-icons task to … 

    …preserve its delicate structure.
    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    70aa784 View commit details
    Browse the repository at this point in the history

  7. Extracted hsl() coordinates of various color custom properties so the… 

    …y can be used with different alpha values.
    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    449b1ef View commit details
    Browse the repository at this point in the history

  8. Enabled the WidgetTypeAround plugin as a dependency of the Widget plu… 

    …gin.
    @oleq
    oleq committed May 7, 2020
    Configuration menu
    Copy the full SHA
    1bf5f34 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Adjusted type around icon color when editing root it blurred. Bound v… 

    …arious dimensions to common custom properties.
    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    300e5ff View commit details
    Browse the repository at this point in the history

  2. Widget selection handle should change its color when the widget is no… 

    …t selected but type around button being hovered on.
    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    bbe23f2 View commit details
    Browse the repository at this point in the history

  3. Docs.

    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    47ce7c5 View commit details
    Browse the repository at this point in the history

  4. Fix: Clicking a type around button in a caption-less image widget sho… 

    …uld insert a paragraph instead of displaying a caption.
    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    c917635 View commit details
    Browse the repository at this point in the history

  5. Tests: Added MediaEmbed to the TypeAround manual test.

    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    99b8063 View commit details
    Browse the repository at this point in the history

  6. Fix: The media embed attribute:url:media converter should not purge t… 

    …he entire content of a widget (including type around UI).
    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    baab447 View commit details
    Browse the repository at this point in the history

  7. Fix: The type around buttons should be aligned symmetrically.

    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    575a8de View commit details
    Browse the repository at this point in the history

  8. Removed line support and mouseover/out activation for the MVP.

    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    88acf31 View commit details
    Browse the repository at this point in the history

  9. Simplified the icon rendering inside insert paragraph buttons.

    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    0164bbc View commit details
    Browse the repository at this point in the history

  10. Fix: Don't add classes to inline widgets.

    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    a41ace9 View commit details
    Browse the repository at this point in the history

  11. Added labels to buttons.

    @oleq
    oleq committed May 8, 2020
    Configuration menu
    Copy the full SHA
    48c1d41 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Tests: Added tests for the WidgetTypeAround plugin.

    @oleq
    oleq committed May 11, 2020
    Configuration menu
    Copy the full SHA
    707fdaf View commit details
    Browse the repository at this point in the history

  2. Tests: Aligned existing widget test to the presence of the type aroun… 

    …d UI in the view.
    @oleq
    oleq committed May 11, 2020
    Configuration menu
    Copy the full SHA
    cb3c9ad View commit details
    Browse the repository at this point in the history

  3. Tests: Aligned image tests to the presence of type around feature in … 

    …widgets.
    @oleq
    oleq committed May 11, 2020
    Configuration menu
    Copy the full SHA
    8e55923 View commit details
    Browse the repository at this point in the history

  4. Docs: Documented the WidgetTypeAround plugin and its utils.

    @oleq
    oleq committed May 11, 2020
    Configuration menu
    Copy the full SHA
    17a9dfa View commit details
    Browse the repository at this point in the history

  5. Refac: Removed dead code from widget type around utils.

    @oleq
    oleq committed May 11, 2020
    Configuration menu
    Copy the full SHA
    1d78977 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into i/407-simple

    @oleq
    oleq committed May 11, 2020
    Configuration menu
    Copy the full SHA
    251329c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Tests: Added manual test description.

    @oleq
    oleq committed May 12, 2020
    Configuration menu
    Copy the full SHA
    8db6e66 View commit details
    Browse the repository at this point in the history

  2. Tests: Added media embed conversion test to make sure it does not int… 

    …erfere with type around UI injected in media widgets.
    @oleq
    oleq committed May 12, 2020
    Configuration menu
    Copy the full SHA
    08abe32 View commit details
    Browse the repository at this point in the history

  3. Tests: Added a test to make sure Widget requires WidgetTypeAround.

    @oleq
    oleq committed May 12, 2020
    Configuration menu
    Copy the full SHA
    67d7c94 View commit details
    Browse the repository at this point in the history

  4. Renamed WidgetTypeAround#typeAround -> `WidgetTypeAround#_insertPar… 

    …agraph`.
    @oleq
    oleq committed May 12, 2020
    Configuration menu
    Copy the full SHA
    897accd View commit details
    Browse the repository at this point in the history

  5. Added missing dev dependencies to package.json.

    @oleq
    oleq committed May 12, 2020
    Configuration menu
    Copy the full SHA
    c0d48e0 View commit details
    Browse the repository at this point in the history

  6. Split the type around styles and moved the theme subset to ckeditor5-… 

    …theme-lark.
    @oleq
    oleq committed May 12, 2020
    Configuration menu
    Copy the full SHA
    8c62940 View commit details
    Browse the repository at this point in the history

  7. Fix: The insert paragraph button should not collide with a widget dra… 

    …g handler.
    @oleq
    oleq committed May 12, 2020
    Configuration menu
    Copy the full SHA
    6ec9bf8 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Update packages/ckeditor5-widget/tests/manual/type-around.md 

    Co-authored-by: Kuba Niegowski <[email protected]>
    @oleq @niegowski
    oleq and niegowski authored May 13, 2020
    Configuration menu
    Copy the full SHA
    0274197 View commit details
    Browse the repository at this point in the history

  2. Update packages/ckeditor5-widget/tests/manual/type-around.md 

    Co-authored-by: Kuba Niegowski <[email protected]>
    @oleq @niegowski
    oleq and niegowski authored May 13, 2020
    Configuration menu
    Copy the full SHA
    ce6c339 View commit details
    Browse the repository at this point in the history

  3. Update packages/ckeditor5-widget/src/widgettypearound/widgettypearoun… 

    …d.js

Co-authored-by: Kuba Niegowski <[email protected]>
    @oleq @niegowski
    oleq and niegowski authored May 13, 2020
    Configuration menu
    Copy the full SHA
    6275452 View commit details
    Browse the repository at this point in the history

  4. Updated table layout post-fixer to properly fix empty rows.

    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    fcf0c62 View commit details
    Browse the repository at this point in the history

  5. Code cleaning - removed redundant check.

    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    559c943 View commit details
    Browse the repository at this point in the history

  6. Table layout post-fixer updated to remove empty rows.

    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    dfee50e View commit details
    Browse the repository at this point in the history

  7. Table row upcast converter skips empty rows.

    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    59e85a7 View commit details
    Browse the repository at this point in the history

  8. Added missing wasFixed flag in post-fixer. Added CK_DEBUG_TABLE to ta… 

    …ble post-fixers.
    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    fddac60 View commit details
    Browse the repository at this point in the history

  9. Rename empty table row upcast converter.

    @jodator @oleq
    jodator authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    126bd23 View commit details
    Browse the repository at this point in the history

  10. Internal: Updated dependencies.

    @mlewand @oleq
    mlewand authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    475e37b View commit details
    Browse the repository at this point in the history

  11. Internal: Updated dependencies.

    @mlewand @oleq
    mlewand authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    a47fa58 View commit details
    Browse the repository at this point in the history

  12. Table heading rows should be properly updated after removing rows as … 

    …a side effect of merging cells.
    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9b64464 View commit details
    Browse the repository at this point in the history

  13. Merging cells and removing empty rows in one batch.

    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e7d528c View commit details
    Browse the repository at this point in the history

  14. Updating heading rows in one enqueued change block (to use the curren… 

    …t table state for update).
    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c175288 View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: Maciej <[email protected]>
    @niegowski @jodator @oleq
    2 people authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    3d4bbc0 View commit details
    Browse the repository at this point in the history

  16. Added the edge case test of removing multiple empty rows after cells … 

    …merge.
    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    528ab6d View commit details
    Browse the repository at this point in the history

  17. The table properties button should not be enabled if all cell propert… 

    …ies commands are disabled.
    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    71200d3 View commit details
    Browse the repository at this point in the history

  18. Table properties button should be disabled if all related commands ar… 

    …e disabled.
    @niegowski @oleq
    niegowski authored and oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ed24dad View commit details
    Browse the repository at this point in the history

  19. Added missing entries to contexts.json.

    @oleq
    oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7ef6fe7 View commit details
    Browse the repository at this point in the history

  20. Docs: Fixed wrong documentation of internal helpers inside the Widget… 

    …TypeAround plugin.
    @oleq
    oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9a4a2a9 View commit details
    Browse the repository at this point in the history

  21. Update packages/ckeditor5-widget/tests/widgettypearound/widgettypearo… 

    …und.js

Co-authored-by: Kuba Niegowski <[email protected]>
    @oleq @niegowski
    oleq and niegowski authored May 13, 2020
    Configuration menu
    Copy the full SHA
    381bcda View commit details
    Browse the repository at this point in the history

  22. Update packages/ckeditor5-widget/tests/widgettypearound/widgettypearo… 

    …und.js

Co-authored-by: Kuba Niegowski <[email protected]>
    @oleq @niegowski
    oleq and niegowski authored May 13, 2020
    Configuration menu
    Copy the full SHA
    bc96819 View commit details
    Browse the repository at this point in the history

  23. Tests: Clean-up in Widget tests.

    @oleq
    oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7821760 View commit details
    Browse the repository at this point in the history

  24. Docs: Made WidgetTypeAround#_insertParagraph a protected method becau… 

    …se it is tested.
    @oleq
    oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9b500fc View commit details
    Browse the repository at this point in the history

  25. Removed an obsolete custom property from widget styles.

    @oleq
    oleq committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2b71a87 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Merge branch 'master' into i/407-simple

    @Reinmar
    Reinmar committed May 14, 2020
    Configuration menu
    Copy the full SHA
    188fa1a View commit details
    Browse the repository at this point in the history

  2. Update packages/ckeditor5-widget/src/widgettypearound/widgettypearoun… 

    …d.js

Co-authored-by: Piotrek Koszuliński <[email protected]>
    @oleq @Reinmar
    oleq and Reinmar authored May 14, 2020
    Configuration menu
    Copy the full SHA
    3c842ec View commit details
    Browse the repository at this point in the history

  3. Made the insert paragraph button titles less technical and more user-… 

    …friendly.
    @oleq
    oleq committed May 14, 2020
    Configuration menu
    Copy the full SHA
    4a9d28f View commit details
    Browse the repository at this point in the history

  4. Update packages/ckeditor5-widget/src/widgettypearound/widgettypearoun… 

    …d.js

Co-authored-by: Piotrek Koszuliński <[email protected]>
    @oleq @Reinmar
    oleq and Reinmar authored May 14, 2020
    Configuration menu
    Copy the full SHA
    c92b4dc View commit details
    Browse the repository at this point in the history

  5. Simplified the insert icon parsing and delivery.

    @oleq
    oleq committed May 14, 2020
    Configuration menu
    Copy the full SHA
    7a3c53e View commit details
    Browse the repository at this point in the history

  6. Used the DowncastWriter instance from the conversionApi to avoid nest… 

    …ed View#change blocks.
    @oleq
    oleq committed May 14, 2020
    Configuration menu
    Copy the full SHA
    d843063 View commit details
    Browse the repository at this point in the history

  7. Tests: Updated widget type around tests to the new button titles.

    @oleq
    oleq committed May 14, 2020
    Configuration menu
    Copy the full SHA
    c06cb6e View commit details
    Browse the repository at this point in the history

  8. Improved the performance of the view post-fixer by keeping track of w… 

    …idgets that have the type around UI injected.
    @oleq
    oleq committed May 14, 2020
    Configuration menu
    Copy the full SHA
    eb42ca5 View commit details
    Browse the repository at this point in the history

  9. Docs: Flattened API docs structure for widget/widgettypearound.

    @oleq
    oleq committed May 14, 2020
    Configuration menu
    Copy the full SHA
    e851b9e View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into i/407-simple

    @Reinmar
    Reinmar committed May 14, 2020
    Configuration menu
    Copy the full SHA
    4fbd1a8 View commit details
    Browse the repository at this point in the history