-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6120: Pasting table into table - base scenarios. #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/ckeditor5-table/src/commands/mergecellscommand.js
…renumbering cells).
niegowski
approved these changes
May 13, 2020
Reinmar
reviewed
May 14, 2020
Reinmar
reviewed
May 14, 2020
Reinmar
reviewed
May 14, 2020
niegowski
approved these changes
May 14, 2020
Thanks for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (table): Introduce pasting tables into a selected table fragment. Closes #6120.
MINOR BREAKING CHANGE: The
cropTable()
utility method was removed. UsecropTableToDimensions()
instead.Additional information
This PR introduces a subset of pasting scenarios limited to:
Other than the above scenarios that were targeted includes:
Additionally, I had to:
Element._clone()
- this will be reported somewhereMergeCellsCommand
- again followup for cleaning the utils mess will be reportedWhat to not review: