Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub issue templates by copying CKEditor 4 templates. #2104

Merged
merged 7 commits into from
Oct 9, 2019
Merged

Stub issue templates by copying CKEditor 4 templates. #2104

merged 7 commits into from
Oct 9, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Oct 8, 2019 •
edited
Loading

Suggested merge commit message (convention)

Internal: Add issue templates. Closes #1191.

Additional information

  • The issue template looks general enough.

@Reinmar
Copy link
Member

Reinmar commented Oct 8, 2019

One idea: use emojis to mark sections in the markdown. Similar to what we use now: ✅, 🔴, etc.

@mlewand mlewand mentioned this pull request Oct 9, 2019
Closed
12 tasks
mlewand
mlewand reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, other than that we're good to go.

.github/ISSUE_TEMPLATE/1-bug-report.md Outdated Show resolved Hide resolved
@jodator jodator marked this pull request as ready for review October 9, 2019 13:19
@mlewand mlewand self-requested a review October 9, 2019 13:59
mlewand
mlewand approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Two minor things that I quickly adjusted during the review: we no longer need old (ancient?) issue template 942d115 and added call for reactions so that we no longer have to do this manually fcc7ac1 😂

@mlewand mlewand merged commit 0eb0937 into master Oct 9, 2019
@mlewand mlewand deleted the t/1191 branch October 9, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlewand mlewand mlewand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use github issues templates (like in CKEditor 4)
3 participants
@jodator @Reinmar @mlewand