-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @ckeditor/ckeditor5-build-*
packages from the ckeditor5
dependencies
#16367
Remove @ckeditor/ckeditor5-build-*
packages from the ckeditor5
dependencies
#16367
Conversation
WalkthroughThe Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…es-from-ckeditor5-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would add a sentence to the proposed commit message about what integrators gain from this change.
Suggested merge commit message (convention)
Other (ckeditor5): Move
@ckeditor/ckeditor5-build-*
packages todevDependencies
to reduce the installation size of theckeditor5
package. Related to #16360.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.