Group changes into one batch #14060
Merged
Group changes into one batch #14060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumluregn
requested changes
May 8, 2023
Dumluregn
requested changes
May 8, 2023
Comment on lines
227
to
236
| it( 'should use parent batch for storing undo steps', () => { | ||
| it( 'should use provided batch', () => { | ||
| setData( model, '<paragraph>a[bc<$text font="foo">fo]obar</$text>xyz</paragraph>' ); | ||
| const batch = model.createBatch(); | ||
| const spy = sinon.spy( model, 'enqueueChange' ); | ||
|
|
||
| model.change( writer => { | ||
| expect( writer.batch.operations.length ).to.equal( 0 ); | ||
| command.execute( { value: 'foo' } ); | ||
| expect( writer.batch.operations.length ).to.equal( 1 ); | ||
| } ); | ||
|
|
||
| expect( getData( model ) ).to.equal( '<paragraph>a[<$text font="foo">bcfo]obar</$text>xyz</paragraph>' ); |
There was a problem hiding this comment.
I think having both tests (the old one and new one) makes sense - depending on whether you've passed the batch as a parameter.
Dumluregn
approved these changes
May 8, 2023
| @@ -20,7 +21,7 @@ describe( 'Integration test Font', () => { | |||
|
|
|||
| return ClassicTestEditor | |||
| .create( element, { | |||
| plugins: [ Font, ArticlePluginSet ], | |||
| plugins: [ Font, ArticlePluginSet, Undo ], | |||
There was a problem hiding this comment.
Undo is included in Essentials which are included in ArticlePluginSet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Group changes into one batch. Closes #3162.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.