Add generic type for watchdog data. #13697
Conversation
| public getItem( itemId: string ): unknown { | ||
| const watchdog = this._getWatchdog( itemId ); | ||
| public getItem( itemId: string ): unknown | undefined { | ||
| try { | ||
| const watchdog = this._getWatchdog( itemId ); | ||
|
|
||
| return watchdog._item; | ||
| return watchdog._item; | ||
| } | ||
| catch { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
I'm not sure if this change is valid, but docs say it should return undefined if not found but it was throwing error instead. If it's valid change, then tests should be adjusted.
|
I think we should abandon this idea for now. This looks complicated and has a very low discoverability. This is not blocking integrations, only shifts responsibility for maintaining either HTML element or editor data used to initialize an editor. |
|
There has been no activity on this PR for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the contribution, leave a comment or reaction under this PR. |
|
We've closed your PR due to inactivity. While time has passed, the core of your contribution might still be relevant. If you're able, consider reopening a similar PR. |
CKEditorBot
added
resolution:expired
Suggested merge commit message (convention)
Feature (watchdog): Add a generic type for watchdog data. See #13541.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.