Keyboard handling for grid components in font color and list style #12202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction instead of children array
…andling-for-grid-components-discovery-solution-1
…andling-for-grid-components-discovery-solution-1
oleq
requested changes
Aug 2, 2022
…een styles but only between other items in dropdown).
…st styles to stylesView from the ListPropertiesView.
…vigation with arrows in one place for all color grids.
…ow left/right) will be handled in addKeyboardHandlingForGrid.
Improves also selection: mouseover and keyboard navigation share the same logic now.
…andling-for-grid-components-discovery-poc
We added new arrow navigation by helper function addKeyboardHandlingForGrid so the focus cycler was not needed anymore.
…der of render() and appendGrids() in unit tests.
…view's own focusTracker.
…andling-for-grid-components-discovery-poc
oleq
requested changes
Aug 9, 2022
packages/ckeditor5-ui/src/bindings/addKeyboardHandlingForGrid.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/src/bindings/addKeyboardHandlingForGrid.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/src/bindings/addKeyboardHandlingForGrid.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/src/bindings/addKeyboardHandlingForGrid.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/tests/bindings/addKeyboardHandlingForGrid.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/src/bindings/addKeyboardHandlingForGrid.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/listproperties/ui/listpropertiesview.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-special-characters/src/ui/charactergridview.js
Outdated
Show resolved
Hide resolved
…ents-discovery-poc
…ct form for clarity and possible extensibility.
oleq
deleted the
ck/11851-keyboard-handling-for-grid-components-discovery-poc
branch
mlewand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (ui): Introduced a common
addKeyboardHandlingForGrid()helper to handle grid keyboard navigation. Closes #11851.Fix (font): Fixed focus order for color grid in font color and background dropdowns. Closes #11841.
Fix (list): Unified focus handling and keyboard navigation in list properties dropdowns. Closes #11041.
Additional information
video3242862938.mp4
video5242862938.mp4