Marker changes did not trigger change:data
#11506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event which resulted in errors in features using markers (for example, annotations not showing up in the sidebar).
scofalik
commented
Mar 22, 2022
Comment on lines
+339
to
+341
| if ( this._changesInElement.size > 0 ) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This was moved to the beginning but it makes sense, if there are any "regular" changes in the differ, return true.
scofalik
commented
Mar 22, 2022
| for ( const { newMarkerData, oldMarkerData } of this._changedMarkers.values() ) { | ||
| if ( newMarkerData.affectsData !== oldMarkerData.affectsData ) { | ||
| return true; | ||
| } | ||
|
|
||
| if ( newMarkerData.affectsData ) { | ||
| // Skip markers, which ranges have not changed. | ||
| if ( newMarkerData.range && oldMarkerData.range && newMarkerData.range.isEqual( oldMarkerData.range ) ) { | ||
| return false; |
There was a problem hiding this comment.
This was incorrect early false, it should have been continue or changed as I did.
scofalik
commented
Mar 22, 2022
Comment on lines
+1671
to
+1677
| it( 'should return `true` if at least one marker changed', () => { | ||
| differ.bufferMarkerChange( 'nameA', { range, affectsData: true }, { range, affectsData: true } ); | ||
| differ.bufferMarkerChange( 'nameB', { range, affectsData: true }, { range: rangeB, affectsData: true } ); | ||
| differ.bufferMarkerChange( 'nameC', { range, affectsData: true }, { range, affectsData: true } ); | ||
|
|
||
| expect( differ.hasDataChanges() ).to.be.true; | ||
| } ); |
There was a problem hiding this comment.
This is a new test, all the other are re-arranged or modified.
|
Oh, that's my fault 🙈 This change looks good to me. |
niegowski
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): Marker changes sometimes did not trigger
change:dataevent which resulted in errors in features using markers (for example, annotations not showing up in the sidebar).