Prevent PlainTableOutput from interfering with other features caption downcast converters
#11407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures caption converters.
dawidurbanski
changed the title
PlainTableOutput from interfering with other features caption downcast converters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (table): Prevent plain table output converter from interfering with other features caption converters. Closes #11394.
Additional information
After some testing we noticed that the new
PlainTableOutputplugin converter for downcasting captions was doing a bit too much. For tables it was correctly changing the output from<figcaption>to<caption>element, but for all the other elements it was falling back to the<figcaption>element. This was preventing other converters to alter this behaviour on their own. Hence this change.