Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed easy integration of blocks, containers, and block objects with DocumentLists through schema #11250

Merged
merged 12 commits into from
Feb 10, 2022

Conversation

oleq
Copy link
Member

@oleq oleq commented Feb 9, 2022

Suggested merge commit message (convention)

Internal (list): DocumentListEditing should extend $container (for blockQuote, etc.), $block (for paragraph, heading2, etc.), and $blockObject (for table, horizontalLine, etc.) with its attributes. Closes #11197.

Feature (engine): Introduced $container, $blockObject, and $inlineObject element types in the model schema for the features to inherit from (see #11197).

Other (html-support): Updated default schema definitions for various elements taking advantage of the $container, $blockObject, and $inlineObject elements in model schema (see #11197).

MINOR BREAKING CHANGE (html-support): The $htmlSection, $htmlObjectBlock, and $htmlObjectInline element types are no longer available for custom elements registered via registerBlockElement() to inherit from. Please use $container, $blockObject, and $inlineObject instead (see #11197).


Additional information

@oleq oleq requested a review from niegowski February 10, 2022 10:19
@oleq oleq marked this pull request as ready for review February 10, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants