Handling tab and shift+tab keys in document lists and an integration with other plugins #11244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ck/10880-tab-key
…. Changed invoked event in tablekeyboard tests from tab to keystrokes.
… command to the indent MultiCommand with a priority.
…gistering them in the indent MultiCommand. Add IndentBlock plugin to documents list manual test.
CatStrategist
changed the title
CatStrategist
changed the title
…ing tests for MultiCommand priority handling.
niegowski
requested changes
Feb 18, 2022
packages/ckeditor5-list/src/documentlist/documentlistediting.js
Outdated
Show resolved
Hide resolved
| } ); | ||
| } ); | ||
|
|
||
| describe( 'outdent command', () => { |
There was a problem hiding this comment.
There is no test with outdent block command executed.
packages/ckeditor5-list/tests/documentlist/integrations/tabobservers.js
Outdated
Show resolved
Hide resolved
… ck/10880-tab-key
niegowski
approved these changes
Feb 23, 2022
|
I just realized that this PR is missing changes in the original list feature. We must remember that both kinds of lists will be available for some time. |
niegowski
reviewed
Feb 24, 2022
This was referenced Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (engine): Introduced
TabObserverthat allows listening to pressing downTabkey.Other (table, code-block):
TabandTab+Shiftkeystrokes handlers now listen totabevent and are executed with respect to context.Internal (list): Implemented handling of
TabandTab+Shiftkeys in document lists. Closes #10880.Internal (list):
indentListandoutdentListcommands are now registered with priority in 'Indent'MultiCommand,TabandTab+Shiftlisteners now executes inlicontext in order to not interfere with other plugins' listeners . Closes #11072.Additional information