Refactor createBlockImageViewElement() helper function. #11236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
The PR should explain why is this change needed and where it originated from. I can see a link in #11187 but I don't understand why is it done. |
|
@Reinmar: PR description updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (image): Refactor
createBlockImageViewElement()helper function.Why: Recently we changed the
slotFor()API by moving it into the writer and renaming the function. This PR aims to do a small refactoring by removing second parameterslotElementwhich is created usingwritersince we already pass the wholewriterinto thecreateBlockImageViewElement().It's documented in another PR review and acts as a follow up to it: #11211 (review)