Added DocumentListStyle command #11232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
requested changes
Feb 7, 2022
| * @protected | ||
| */ | ||
| execute( options = {} ) { | ||
| this._tryToConvertItemsToList( options ); |
There was a problem hiding this comment.
You should wrap both model changes (changing the list type and changing the list style) in a single change block, otherwise, it would generate 2 separate undo steps.
niegowski
requested changes
Feb 8, 2022
| } | ||
| this._tryToConvertItemsToList( options ); | ||
|
|
||
| model.enqueueChange( writer.batch, writer => { |
There was a problem hiding this comment.
This should not be required, commands executed inside a change block will automatically be a part of the outermost change block.
There was a problem hiding this comment.
I guess you needed this to make the following blocks pass the block.hasAttribute( 'listStyle' ) test that was added by the post-fixer after the first change block and before the enqueueChange block but you could check whether the selected blocks are list items at all.
packages/ckeditor5-list/src/documentlistproperties/documentliststylecommand.js
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlistproperties/documentliststylecommand.js
Show resolved
Hide resolved
packages/ckeditor5-list/tests/documentlist/documentlistcommand.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/tests/documentlistproperties/documentliststylecommand.js
Outdated
Show resolved
Hide resolved
|
I pushed some proposals of changes: 6a84586. |
niegowski
reviewed
Feb 9, 2022
packages/ckeditor5-list/src/documentlistproperties/documentliststylecommand.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (list): Adds
DocumentListStyleCommand. See #11166.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.