Ck/11065 document list properties #11099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list-properties # Conflicts: # packages/ckeditor5-list/tests/documentlist/_utils/utils.js # packages/ckeditor5-list/tests/documentlist/utils/model.js # packages/ckeditor5-list/tests/documentlist/utils/postfixers.js
…command Internal (list): Adds `DocumentListStartCommand` and `DocumentListReversedCommand`. Closes #11166.
…list-properties # Conflicts: # packages/ckeditor5-list/src/listproperties.js
oleq
requested changes
Feb 17, 2022
There was a problem hiding this comment.
There are few eslint errors in the package
yarn eslint packages/ckeditor5-list
yarn run v1.22.17
$ /Users/oleq/ck/5/ckeditor5/node_modules/.bin/eslint packages/ckeditor5-list
/Users/oleq/ck/5/ckeditor5/packages/ckeditor5-list/tests/documentlistproperties/converters.js
184:4 warning Test title is used multiple times in the same test suite mocha/no-identical-title
904:4 warning Test title is used multiple times in the same test suite mocha/no-identical-title
961:4 warning Test title is used multiple times in the same test suite mocha/no-identical-title
1555:4 warning Test title is used multiple times in the same test suite mocha/no-identical-title
2218:4 warning Test title is used multiple times in the same test suite mocha/no-identical-title
/Users/oleq/ck/5/ckeditor5/packages/ckeditor5-list/tests/list/listediting.js
509:5 warning Test suite title is used multiple times mocha/no-identical-title
/Users/oleq/ck/5/ckeditor5/packages/ckeditor5-list/tests/todolist/todolistediting.js
1172:4 warning Test title is used multiple times in the same test suite mocha/no-identical-title
✖ 7 problems (0 errors, 7 warnings)
packages/ckeditor5-list/src/documentlist/documentlistediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlist/documentlistediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlist/documentlistediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlist/documentlistediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlistproperties/documentlistpropertiesediting.js
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlistproperties/converters.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlistproperties/converters.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlistproperties/documentlistreversedcommand.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-list/src/documentlistproperties/documentlistreversedcommand.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Kuba Niegowski <[email protected]>
…list-properties # Conflicts: # packages/ckeditor5-list/src/documentlist/documentlistediting.js
…ties-post-fixer Internal (list): Adds post-fixer that makes sure that all items in a single list have the same start, reversed, and style properties. Closes #11167.
…s-on-indent Internal (list): Reset document list properties after indent. Closes #11357.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (list): Introducing the document list properties feature. Closes #11065.
Internal (engine): Added option for the
DomConverterto transparently render only the content of the element in the data pipeline.Additional information