Introduced batch sub-types #11009
Merged
Introduced batch sub-types #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Local`, `isUndo`, `isTyping` which better represent the batch type. `Batch` constructor and `Model#enqueueChange()` now expect an object. Fix (typing): Fixed editor crash when an unrecognized transformation was given in configuration (as a string). Other (typing): Typing feature will now create batches with `isTyping` set to `true`. Other (undo): Undo feature will now create batches with `isUndo` set to `true`. MINOR BREAKING CHANGE: String value for `Batch` type and `Model#enqueueChange()` is now deprecated. Using string value will log a warning in the console. Use an object value instead. For more information, refer to the API documentation.
scofalik
commented
Dec 15, 2021
| .map( transformation => TRANSFORMATIONS[ transformation ] || transformation ) | ||
| .filter( transformation => typeof transformation === 'object' ) // Filter out transformations set as string that has not been found. |
There was a problem hiding this comment.
An existing test started to fail after the batch changes has been introduced. This was a fix that was needed. It seems that previously, the test was a false positive.
niegowski
requested changes
Jan 3, 2022
Co-authored-by: Kuba Niegowski <[email protected]>
niegowski
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Replaced
Batch#typewith a set of flags:isUndoable,isLocal,isUndo,isTypingwhich better represent the batch type.Batchconstructor andModel#enqueueChange()now expect an object. Closes #10967.Fix (typing): Fixed editor crash when an unrecognized transformation was given in configuration (as a string).
Other (typing): Typing feature will now create batches with
isTypingset totrue.Other (undo): Undo feature will now create batches with
isUndoset totrue.BREAKING CHANGE (engine):
Batch#typehas been removed. UseBatch#isUndoable,#isLocal,#isUndoand#isTypinginstead.BREAKING CHANGE (typing):
Input#isInput()has been removed. UseBatch#isTypinginstead.MINOR BREAKING CHANGE (engine): String value for
Batchtype andModel#enqueueChange()is now deprecated. Using string value will log a warning in the console. Use an object value instead. For more information, refer to the API documentation.