Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputTextView should update its #isEmpty property more often #10713

Merged
merged 1 commit into from
Oct 19, 2021
Merged

InputTextView should update its #isEmpty property more often #10713

merged 1 commit into from
Oct 19, 2021

Conversation

oleq
Copy link
Member

@oleq oleq commented Oct 18, 2021

Suggested merge commit message (convention)

Fix (ui): InputTextView should update its #isEmpty property on every #input instead of #change to stay in sync. Closes #10431.

@dawidurbanski dawidurbanski self-requested a review October 19, 2021 08:22
dawidurbanski
dawidurbanski approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@dawidurbanski dawidurbanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dawidurbanski dawidurbanski merged commit f5f65d3 into master Oct 19, 2021
@dawidurbanski dawidurbanski deleted the ck/10431-labeled-field-label-clash branch October 19, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawidurbanski dawidurbanski dawidurbanski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LabeledFieldView with a value renders label incorrectly when disabled
2 participants
@oleq @dawidurbanski