Table rows and columns reordering when headingRows or headingColums is set
#10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adingColumns attribute.
dawidurbanski
changed the title
headingRows or headingColums set
dawidurbanski
changed the title
headingRows or headingColums setheadingRows or headingColums is set
…Columns in viewTable util. Warn if headingColumns is used.
dawidurbanski
commented
Sep 16, 2021
| tablesToRefresh.add( element ); | ||
| } | ||
| } else { | ||
| /* istanbul ignore else */ |
There was a problem hiding this comment.
Alternatively instead of nested if with ignored else we can completely drop below check:
if ( change.type === 'insert' || change.type === 'remove' ) {
niegowski
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (table): Make reordering table rows and columns possible without breaking view in tables with
headingRowsorheadingColumnsis set. Closes #10463.