Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict mathematical text transformation not to interfere with dates #10528

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

arkflpc
Copy link
Contributor

@arkflpc arkflpc commented Sep 14, 2021

Suggested merge commit message (convention)

Fix (typing): Restricts mathematical text transformation, so it requires no alphanumeric character before and after the fraction. Closes #9170.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@arkflpc arkflpc requested a review from niegowski September 14, 2021 13:29
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented below. Also, is there a follow-up issue for the enter key handling as mentioned here?

packages/ckeditor5-typing/src/texttransformation.js Outdated Show resolved Hide resolved
@niegowski niegowski merged commit e228a7e into master Sep 17, 2021
@niegowski niegowski deleted the ck/9170 branch September 17, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic text transformation : create dates fraction
2 participants