Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow storing comment's content as the $root attribute #10286

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Allow storing comment's content as the $root attribute #10286

merged 1 commit into from
Aug 2, 2021

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Aug 2, 2021

Suggested merge commit message (convention)

Fix (html-support): Extended schema definition for $root to allow storing comment's content as the $root attribute. Closes #10274.

@maxbarnas maxbarnas self-requested a review August 2, 2021 07:51
@maxbarnas
Copy link
Contributor

Works like a charm! 🎉

@maxbarnas maxbarnas merged commit 35b08a9 into master Aug 2, 2021
@maxbarnas maxbarnas deleted the ck/10274 branch August 2, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbarnas maxbarnas Awaiting requested review from maxbarnas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML comment: comments' content is lost but comments' markers still exist
2 participants
@psmyrek @maxbarnas