Content minimap MVP1 #10090
Merged
Content minimap MVP1 #10090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
reviewed
Jul 6, 2021
There was a problem hiding this comment.
Shouldn't we disable processing the package by CI? Otherwise, we will have red builds on CI because of a lack of coverage. See: f484532.
Also, please, do not use [skip ci] for the last commit when creating PR. It prevents creating a Travis build.
As for the review, I checked the repository state. As for the code, I didn't go too deep, so another pair of eyes will probably be required here.
…ent is rendered multiple times (e.g. in an iframe of a minimap).
pomek
approved these changes
Jul 7, 2021
Co-authored-by: Kamil Piechaczek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (minimap): Basic implementation of the content minimap feature. Closes #10079.
Additional information
P.S. When reviewing keep in mind this is a feature preview without tests and on top of an unstable API.