Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHS] Applying attributes to existing features - media embed #9918

Closed
jacekbogdanski opened this issue Jun 18, 2021 · 2 comments · Fixed by #10226
Closed

[GHS] Applying attributes to existing features - media embed #9918

jacekbogdanski opened this issue Jun 18, 2021 · 2 comments · Fixed by #10226
Assignees
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jacekbogdanski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

Due to the complex model structure of the Media Embed feature, it's not possible to easily extend it with additional attributes. We will need to create separate integration for it.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jacekbogdanski jacekbogdanski added type:bug This issue reports a buggy (incorrect) behavior. squad:compat domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. labels Jun 18, 2021
@Mgsy
Copy link
Member

Mgsy commented Jul 8, 2021

It seems that media embed allows defining different outputs (e.g. coming from external providers like iframely). Basically, we have two output types - semantic and non-semantic.

TODO: Check how the model looks like.

Let's start with small research.

@Reinmar
Copy link
Member

Reinmar commented Jul 22, 2021

Scope after the research:

  • Support the configurable oembed element name.
  • Tests.
  • API docs.

Note: We do not plan to support extending the preview markup (when previewInData is true). Read more in #10108.

psmyrek added a commit that referenced this issue Jul 28, 2021
Feature (html-support): Added General HTML Support integration for Media Embed feature. Closes #9918.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants