Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement picture element support in the image feature #9833

Closed
oleq opened this issue Jun 8, 2021 · 0 comments · Fixed by #9941
Closed

Implement picture element support in the image feature #9833

oleq opened this issue Jun 8, 2021 · 0 comments · Fixed by #9941
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 45 (v29...

Comments

@oleq
Copy link
Member

oleq commented Jun 8, 2021

📝 Provide a description of the new feature

ATM only <img srcset="..." sizes="..." /> is supported. To further explore the responsive images (including art direction) and allow fallback for unsupported image types, <picture> must be supported.

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@oleq oleq added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:image domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Jun 8, 2021
@oleq oleq added this to the iteration 44 milestone Jun 8, 2021
@oleq oleq self-assigned this Jun 8, 2021
@oleq oleq mentioned this issue Jun 21, 2021
Merged
@Reinmar Reinmar modified the milestones: iteration 44, Iteration 45 Jul 4, 2021
@oleq oleq changed the title Research picture element support in the image feature Implement picture element support in the image feature Jul 5, 2021
@oleq oleq mentioned this issue Jul 5, 2021
Closed
maxbarnas added a commit that referenced this issue Jul 20, 2021
@maxbarnas
Merge pull request #9941 from ckeditor/ck/9833-picture-element-support
9a265d1 
Feature (image): Implemented the <picture> element support in the image feature. Closes #9833.

MINOR BREAKING CHANGE (image): Several conversion helpers have been renamed and removed from the public API (viewFigureToModel() -> upcastImageFigure(), srcsetAttributeConverter() -> downcastSrcsetAttribute(), modelToViewAttributeConverter() -> downcastImageAttribute()).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 45 (v29.1.0)
Development

Successfully merging a pull request may close this issue.

#9833 Picture element support ckeditor/ckeditor5
2 participants
@Reinmar @oleq