Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchdog should not import CKEditor 5 utils as this leads to package duplication problem in integrations #9315

Closed
ma2ciek opened this issue Mar 22, 2021 · 2 comments · Fixed by #9327
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Mar 22, 2021

In other words, we should get rid of this line:

import { toArray } from 'ckeditor5/src/utils';

And write the `toArray()` utility for this package independently.

The current situation leads to the package duplication problem because the watchdog is bundled in the integration library independently from the CKEditor 5 bundle.

@Reinmar
Copy link
Member

Reinmar commented Mar 22, 2021

It worked so far because we imported that function directly from its file, hence we didn't import index.js hence we didn't import EmitterMixin (imported by index.js) hence we didn't trigger the error.

@Reinmar
Copy link
Member

Reinmar commented Mar 22, 2021

toArray is a one line, let's inline it and remove this dep completely.

@Reinmar Reinmar added this to the iteration 42 milestone Mar 22, 2021
ma2ciek added a commit that referenced this issue Mar 23, 2021
Fix (watchdog): Removed import from the ckeditor5 package. Closes #9315.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants