Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code should not be copied to a new line on Enter #8144

Closed
Reinmar opened this issue Sep 24, 2020 · 1 comment · Fixed by #8408
Closed

Code should not be copied to a new line on Enter #8144

Reinmar opened this issue Sep 24, 2020 · 1 comment · Fixed by #8408
Assignees
@pkwasnik
Labels
intro Good first ticket. package:basic-styles package:enter squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 38 (v24...

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 24, 2020

📝 Provide a description of the improvement

Unlike bold or italic, which people seem to expect to be copied to a new line when you press Enter, <code> makes no sense at all. I find it very annoying when using GH Writer and writing content like this:

I was absolutely not expecting "The" to be wrapped in <code>.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@Reinmar Reinmar added type:improvement This issue reports a possible enhancement of an existing feature. package:basic-styles package:enter squad:core Issue to be handled by the Core team. intro Good first ticket. labels Sep 24, 2020
@Reinmar Reinmar mentioned this issue Sep 24, 2020
Closed
@jodator
Copy link
Contributor

jodator commented Sep 24, 2020

Having <code> act the same way as <link> seems OK to me.

@mlewand mlewand added this to the nice-to-have milestone Oct 5, 2020
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 38 Nov 2, 2020
@pkwasnik pkwasnik mentioned this issue Nov 3, 2020
Merged
jodator added a commit that referenced this issue Nov 4, 2020
@jodator
Merge pull request #8408 from ckeditor/i/8144
000aeb6 
Fix (basic-styles): Code should not be copied to a new line on <kbd>Enter</kbd> key. Closes #8144.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
intro Good first ticket. package:basic-styles package:enter squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Code should not be copied to a new line on Enter ckeditor/ckeditor5
4 participants
@Reinmar @jodator @mlewand @pkwasnik