-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling resize handles when using resize buttons #7579
Comments
What about this:
Right now, you enable If you'll want buttons only – you'll load If you'll want handles only – you'll load Do I miss something? |
No, this is also a way to go. I like the naming, so probably it is a way to go :) |
@Reinmar your granular approach is OK, but IMHO it'd be nice to have the opt-out option ( |
We tend to have less config options if possible so configuring (opting-out) by plugins configuration in build would be OK. |
Exactly. |
Other (image): Allow to configure `ImageResize` in a more granular way. For example, by combining `ImageResizeEditing` with `ImageResizeHandles` or `ImageResizeButtons` to resize image by handles or by image toolbar UI components (dropdown or standalone buttons) respectively. Closes #7579. Docs (image): Add a new section to feature documentation for the `Image` plugin about disabling image resize handles. Internal (image): Separate `ImageResizeHandles` plugin from the `ImageResizeEditing`. Tests (image): Refactor unit tests for `ImageResizeHandles` and `ImageResizeEditing`.
Provide a description of the task
The
ImageResize
plugin was refactored to common glue plugin that requires:ImageResizeEditing
- for command and image resize handlesImageResizeUI
- for dropdown and buttonsHowever, we've identified that not everybody would like to have buttons and resize handles and it would be nice to configure
ImageResizeEditing
feature so that handles are optional (as opt-out to have backward compatibility if possible).I can see two options:
ImageResizeEditing
to two - but the question remains how to name the resulting plugins (and how to keep backward compatibility for previousImageResize
plugin - or introduce breaking change.config.imageResizeHandles: false
(or similar).The text was updated successfully, but these errors were encountered: