Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element in the block quote doesn't remove if selection contains three block elements #733

Closed
Mgsy opened this issue Dec 19, 2017 · 3 comments
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Mgsy
Copy link
Member

Mgsy commented Dec 19, 2017

🐞 Is this a bug report or feature request? (choose one)

  • Bug report

💻 Version of CKEditor

1.0.0-alpha2

📋 Steps to reproduce

  1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Start the selection in the first block quote's paragraph and move it to the OL List item 2.
  3. Press delete.

✅ Expected result

Paragraph, image and list item have been removed.

❎ Actual result

Only image and list item have been removed.

📃 Other details that might be useful

GIF
bug_cke5

Notes
If you try to put the selection in the paragraph which should be deleted, you'll get the notification in the console:

model-selection-range-in-graveyard: Trying to add a Range that is in the graveyard root. Range rejected. Read more: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/framework/guides/support/error-codes.html#model-selection-range-in-graveyard
 undefined

If you try to make undo, the paragraph will be restored.

This bug is reproducible only if the selection contains at least one block from the block quote and two blocks from outside the block quote.

I'm not able to reproduce it in https://ckeditor5.github.io/, so it might be a regression

Other information
OS: Windows 10, MacOS X
Browser: All browsers

@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 19, 2017
@Reinmar
Copy link
Member

Reinmar commented Jan 17, 2018

It's indeed some kind of a regression. Looks like a differ, but I'm not sure whether on 19 Dec we had a differ already.

cc @scofalik

@Reinmar Reinmar added this to the iteration 14 milestone Jan 17, 2018
@Reinmar Reinmar assigned Reinmar and scofalik and unassigned Reinmar Jan 24, 2018
@scofalik
Copy link
Contributor

Yes, I found what causes the bug and it is indeed a bug in differ. I am on it.

@scofalik
Copy link
Contributor

Will be fixed by ckeditor/ckeditor5-engine#1316

Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Feb 22, 2018
Fix: Corrected how change items in `model.Differ` are dismissed if they are in inserted/removed parent. Closes ckeditor/ckeditor5#733.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants