-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Word table and pasting into CKE5 loses table cell background color #7275
Comments
Looks like a regression was working in v17: https://ckeditor.com/docs/ckeditor5/17.0.0/features/pasting/paste-from-word.html#demo |
Since this will require bisecting changes before our migration to monorepo, this will be useful: https://ckeditor.com/docs/ckeditor5/17.0.0/framework/guides/contributing/development-environment.html#bisecting-through-a-multi-repository |
BTW, from some reports that I saw, I gather that font colors and other font styles may be lost now too. We need to check all the formatting here. To whoever will work on this:
In other words – use the same setup as in the Paste from Word demo in the docs. |
#7295 (comment) contains some really interesting findings about setups that don't work. The issue is much wider than just about tables (or we have two different regressions at the same time, which is unlikely). |
Fix (paste-from-office): The Paste from Office feature should use the same instance of `StylesProcessor` as the view document. Closes #7275.
@Reinmar @mlewand @niegowski @oleq Thank you for the quick turn! |
Fix (paste-from-office): The Paste from Office feature should use the same instance of `StylesProcessor` as the view document. Closes #7275.
📝 Provide detailed reproduction steps (if any)
✔️ Expected result
Copied table cell background colors from Word document are properly transferred to Ckeditor5 as described at Table styles compatibility with CKEditor 4 and office suites (Word, Excel, Google Docs) #5652.
❌ Actual result
Table loses cell background color data after it is pasted into CKE. This appears to be happening in upcasting (?); some table cell inline styles are transferred to attributes, while others are not.
📃 Other details
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: