Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow others to create table with headings #6768

Closed
jodator opened this issue May 8, 2020 · 1 comment · Fixed by #7597
Closed

Allow others to create table with headings #6768

jodator opened this issue May 8, 2020 · 1 comment · Fixed by #7597
Assignees
Labels
intro Good first ticket. package:table type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@jodator
Copy link
Contributor

jodator commented May 8, 2020

📝 Provide a description of the improvement

We have two ways of inserting tables:

  1. insertTable command
  2. TableUtils.createTable() (used by the command)

Both allows to create table of given dimensions. I think that we could add headingRows and headingColumns to allow creating tables with headings.

Related: #6734.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. package:table intro Good first ticket. labels May 8, 2020
@Mgsy Mgsy added this to the backlog milestone May 11, 2020
@fredck
Copy link
Contributor

fredck commented May 22, 2020

FYI, I've worked-this-issue-around in GitHub Writer with this commit.

Basically, I'm executing "setTableRowHeader" right after "insertTable".

The drawback is that this creates a double undo step for the table insertion. Additionally, if the user undoes just the last step, the table will lose the header, which may be unexpected.

@Reinmar Reinmar modified the milestones: backlog, iteration 34 Jun 23, 2020
@niegowski niegowski self-assigned this Jul 9, 2020
jodator added a commit that referenced this issue Jul 13, 2020
Feature (table): Added option to set heading rows and columns for `insertTable` command and `TableUtils#createTable()`. Closes #6768.

MINOR BREAKING CHANGE (table): The parameters of `TableUtils#createTable()` has changed. Use `options` object to pass number of `rows` and `columns`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
5 participants