Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table properties buttons miss isEnabled binding with commands #6679

Closed
Mgsy opened this issue Apr 27, 2020 · 0 comments · Fixed by #6759
Closed

Table properties buttons miss isEnabled binding with commands #6679

Mgsy opened this issue Apr 27, 2020 · 0 comments · Fixed by #6759
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:table support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mgsy
Copy link
Member

Mgsy commented Apr 27, 2020

📝 Provide detailed reproduction steps (if any)

Currently, table properties buttons don't become disabled after disabling all related commands. See the example below:

const commands = [ 
    'tableCellBorderStyle', 
    'tableCellBorderColor', 
    'tableCellBorderWidth', 
    'tableCellHorizontalAlignment', 
    'tableCellWidth', 
    'tableCellHeight', 
    'tableCellPadding', 
    'tableCellBackgroundColor', 
    'tableCellVerticalAlignment'
]

commands.forEach( command => editor.commands.get( command ).forceDisabled() );

✔️ Expected result

Screenshot 2020-04-27 at 12 54 37

❌ Actual result

Screenshot 2020-04-27 at 12 56 38


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Apr 27, 2020
@Mgsy Mgsy changed the title Table properties buttons miss bindings with commands Table properties buttons miss isEnabled binding with commands Apr 27, 2020
@Mgsy Mgsy added the domain:ui/ux This issue reports a problem related to UI or UX. label Apr 27, 2020
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Apr 27, 2020
@jodator jodator added the intro Good first ticket. label Apr 30, 2020
@jodator jodator added this to the iteration 32 milestone Apr 30, 2020
@niegowski niegowski self-assigned this May 6, 2020
jodator added a commit that referenced this issue May 13, 2020
Fix (table): The table properties button should not be enabled if all properties commands are disabled. Closes #6679.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:table support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
5 participants