Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselection breaks in tables while holding Shift key #6453

Closed
panr opened this issue Mar 17, 2020 · 0 comments · Fixed by #6730
Closed

Multiselection breaks in tables while holding Shift key #6453

panr opened this issue Mar 17, 2020 · 0 comments · Fixed by #6730
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table type:bug This issue reports a buggy (incorrect) behavior.

Comments

@panr
Copy link
Contributor

panr commented Mar 17, 2020

📝 Provide detailed reproduction steps (if any)

  1. Select the cell somewhere in the middle of a table.
  2. Holding Shift key, select another cell in the top-left corner of the table.
  3. Still holding Shift, select another cell but this time in the top-right corner.
    • Chrome, Edge:
      - Selection breaks ❌, but the right anchor cell is still selected ✅. When you click second time on the cell you wanted to select in the [3], selection re-appears ✅.
      - But when you change direction to the bottom, then selection is still active ✅, but the anchor point is lost ❌…
    • Safari, Firefox:
      - Selection breaks ❌, but this time we immediately loose anchor cell ❌. Newly selected cell becomes the anchor now ❌.

⚠️In every screencast below I keep holding Shift key all the time. 👇🏻

✔️ Expected result

Should be similar to the native apps (Pages) or even Google Docs:

Pages

pages

Google Docs

googledocs

❌ Actual result

Chrome, Edge

multiselection

Safari

safari

Firefox

firefox

📃 Other details

It seems that in Chrome and Edge it works slightly better than in the other browsers.

--
If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@panr panr added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. package:table labels Mar 17, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Mar 24, 2020
@jodator jodator modified the milestones: nice-to-have, iteration 32 Apr 30, 2020
@niegowski niegowski self-assigned this Apr 30, 2020
jodator added a commit that referenced this issue May 8, 2020
Fix (table): Shift+click will now use anchor cell if there is any. Closes #6453.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants