Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safari] Balloon editor toolbar should always expand when there's enough space #6444

Closed
oleq opened this issue Mar 16, 2020 · 4 comments · Fixed by #7795
Closed

[Safari] Balloon editor toolbar should always expand when there's enough space #6444

oleq opened this issue Mar 16, 2020 · 4 comments · Fixed by #7795
Assignees
@oleq
Labels
browser:safari domain:ui/ux This issue reports a problem related to UI or UX. package:editor-balloon package:utils type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 35 (v22...

Comments

@oleq
Copy link
Member

oleq commented Mar 16, 2020

📝 Provide detailed reproduction steps (if any)

  1. Open the balloon editor and make a selection.
  2. Scale down the browser.
  3. Hide the toolbar.
  4. Expand the window.
  5. Make a selection again.

2020-03-16 13 11 39

✔️ Expected result

The toolbar should look like before 1.

❌ Actual result

The toolbar looks like after 1.

📃 Other details

It works correctly in other browsers because unlike Safari, they don't use polyfilled ResizeObserver. I think something's wrong with the polyfill, maybe it should be improved.

cc @panr

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. browser:safari package:editor-balloon labels Mar 16, 2020
@oleq oleq added this to the iteration 30 milestone Mar 16, 2020
@oleq oleq added domain:ui/ux This issue reports a problem related to UI or UX. package:utils labels Mar 16, 2020
@panr
Copy link
Contributor

panr commented Mar 16, 2020

Oh boy... Safari 🙄

@mlewand mlewand modified the milestones: iteration 30, iteration 31 Mar 16, 2020
@panr panr self-assigned this Mar 19, 2020
@Reinmar Reinmar modified the milestones: iteration 31, nice-to-have Apr 16, 2020
@panr
Copy link
Contributor

panr commented Jun 3, 2020

Fun fact. Just tested it in Safari 13.1.1 which supports ResizeObserver and... it's still broken BUT... even "funnier" fact — it's also broken in other browsers... It looks like the bug lies somewhere else...

@oleq
Copy link
Member Author

oleq commented Jun 4, 2020

It looks like we can finally get rid of the polyfill. 🎉

@oleq
Copy link
Member Author

oleq commented Jun 4, 2020

It looks like the resize observer does not kick in when the toolbar re-appears. It works when the editable starts to re-scale again, though. Have fun! :P

@panr panr mentioned this issue Jul 27, 2020
Closed
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 35 Jul 31, 2020
@panr panr removed their assignment Aug 6, 2020
@oleq oleq mentioned this issue Aug 6, 2020
Merged
@oleq oleq self-assigned this Aug 6, 2020
@panr panr closed this as completed in #7795 Aug 7, 2020
panr added a commit that referenced this issue Aug 7, 2020
@panr
Merge pull request #7795 from ckeditor/i/6444-toolbar-reposition-on-r…
3252378 
…egroup

Fix (ui): Balloon toolbar should reposition and ungroup items correctly when the window resizes. Closes #6444.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
browser:safari domain:ui/ux This issue reports a problem related to UI or UX. package:editor-balloon package:utils type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 35 (v22.0.0)
4 participants
@Reinmar @oleq @panr @mlewand